Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required updates from Figma for dynamic pages #84

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ryansrofe
Copy link
Collaborator

Description

Figma requires these updates to release a new version of FigLog. Pretty simple. We will need to add their linter to safeguard for future updates however we are currently not using API features that require it. It requires upgrading to eslint. A new task will be created for this piece.

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally in Figma.

@ryansrofe ryansrofe added the chore Chore and admin type task label Apr 16, 2024
@ryansrofe ryansrofe added this to the Version 3 milestone Apr 16, 2024
@ryansrofe ryansrofe requested a review from cpresler April 16, 2024 19:05
@ryansrofe ryansrofe linked an issue Apr 16, 2024 that may be closed by this pull request
@ryansrofe ryansrofe self-assigned this Apr 16, 2024
Copy link
Contributor

@cpresler cpresler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! When we update to eslint we should incorporate the prettier stuff into that as well so we're not running multiple checks on similar things.

@ryansrofe ryansrofe merged commit 5bb1e9b into main Apr 17, 2024
1 check passed
@ryansrofe ryansrofe deleted the required-figma-update branch April 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore and admin type task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Widget to Dynamically Loaded Pages
2 participants