Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniel/fix core var handlers --> main #105

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Daniel/fix core var handlers --> main #105

wants to merge 33 commits into from

Conversation

YoungMasterGandalf
Copy link
Collaborator

@YoungMasterGandalf YoungMasterGandalf commented Oct 31, 2024 •
edited
Loading

Contains:

  • fixes DictionaryModifyHandler (there were some bugs, issues and deprecated legacy code)
  • changes DictionaryModifyHandler behaviour to be more pythonic (in-place changes etc.) similarly to list modify handler
  • code cleaning and formatting (here and there)
  • fixes bugs in ListModifyHandler -- see https://forloopai.slack.com/archives/C01KP2U7CR1/p1729953818395679

@YoungMasterGandalf
Refactor _get_value_by_key method
eb67f23
@YoungMasterGandalf
Refactor _join_dictionaries method
93e7210
@YoungMasterGandalf
Refactor _delete_dict_entry method
82eb23c
@YoungMasterGandalf
Add return to _delete_dict_entry method
948cbb1
@YoungMasterGandalf
Refactor _add_dict_entry method
85de42a
@YoungMasterGandalf
Refactor _invert_dictionary method
2ff65c8
@YoungMasterGandalf
Refactor DictionaryModifyHandler direct_execute for DB var checking, …
698df10 
…rename args, improve error handling
@YoungMasterGandalf
Introduce _evaluate_argument method to AbstractFunctionHandler
2cbf535
@YoungMasterGandalf
Format DictionaryModifyHandler parts
ade4e06
@YoungMasterGandalf
Sort and clean variable_handlers.py imports
04e3d09
@YoungMasterGandalf
Introduce validate_hashable_dict_key auciliary function
c247cad
@YoungMasterGandalf
Use validate_hashable_dict_key auxiliary func in DictionaryModifyHandler
6c4bf77
@YoungMasterGandalf
Reorder methods in DictModifyHandler to standard ordering
abe6cd8
@YoungMasterGandalf
Delete execute_with_params from DictModifyHandler
b06d51d
@YoungMasterGandalf
Add pass_syntax_err argument to _evaluate_argument method
e618ba7
@YoungMasterGandalf
Refactor NewVariableHandler
f26b098
@YoungMasterGandalf
Rename variable_name to var_name
81fc955
@YoungMasterGandalf
Rename variable_value to var_value
9228a51
@YoungMasterGandalf
Fix passing of err in _evaluate_argument method
4c7482f
@YoungMasterGandalf
Add new var name check to DictModifyHandler
def48a6
@YoungMasterGandalf
Delete commented deprecated imports
d3e266b
@YoungMasterGandalf
Delete commented code
3589b6f
@YoungMasterGandalf
Remove unused input_execute
46ac1cc
@YoungMasterGandalf
Improve MathModify direct_execute
8ad401f
@YoungMasterGandalf
Format MathModify init_docs
1a7c0e7
@YoungMasterGandalf
Improve resolve_type_error_list error handling
5142e1f
@YoungMasterGandalf
Rename variable_type to new_var_type
a9119d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DovaX DovaX Awaiting requested review from DovaX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YoungMasterGandalf