fix: activity href (#193)

* fix: activity href * tests: update activity test
ForkbombEu · Dec 13, 2024 · 3d49481 · 3d49481
1 parent 99fb04d
commit 3d49481
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/components.d.ts b/src/components.d.ts
@@ -13,6 +13,7 @@ export namespace Components {
     interface DActivityCard {
         "date": string;
         "description": string;
+        "href"?: string;
         "logo": string;
         "message": string;
         "read": boolean;
@@ -613,6 +614,7 @@ declare namespace LocalJSX {
     interface DActivityCard {
         "date"?: string;
         "description"?: string;
+        "href"?: string;
         "logo"?: string;
         "message"?: string;
         "read"?: boolean;

diff --git a/src/components/activity-card/d-activity-card.tsx b/src/components/activity-card/d-activity-card.tsx
@@ -11,11 +11,12 @@ export class DActivityCard {
   @Prop({ reflect: true }) description: string;
   @Prop({ reflect: true }) date: string;
   @Prop({ reflect: true }) read: boolean = false;
+  @Prop({ reflect: true }) href?: string;
 
   render() {
     return (
       <Host>
-        <d-list-item name={this.message} logo-src={this.logo} href="#" description={this.description}>
+        <d-list-item name={this.message} logo-src={this.logo} href={this.href} description={this.description}>
           <div slot="date">
             <div class="flex items-center gap-2.5">
               {!this.read && <d-info-led type="warning" />}

diff --git a/src/components/activity-card/test/d-activity-card.spec.tsx b/src/components/activity-card/test/d-activity-card.spec.tsx
@@ -10,7 +10,7 @@ describe('d-activity-card', () => {
     expect(page.root).toEqualHtml(`
       <d-activity-card>
         <mock:shadow-root>
-         <d-list-item href="#">
+         <d-list-item>
             <div slot="date">
               <div class="flex gap-2.5 items-center">
                 <d-info-led type="warning"></d-info-led>