Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] rma: _check_move_partner compare with RMA commercial partner #552

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

AlexPForgeFlow
Copy link
Contributor

When an origin move is selected in an RMA, make the check if the picking address is equal to the delivery address from the RMA customer, instead of the customer address.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but maybe it is too restrictive? maybe checking the commercial partner would be enough and do not block cases in which you will deliver to a different location?

@AlexPForgeFlow AlexPForgeFlow force-pushed the 16.0-fix-check_move_partner-rma branch 2 times, most recently from c00997e to 255ee40 Compare November 5, 2024 09:58
@AlexPForgeFlow
Copy link
Contributor Author

Makes sense, but maybe it is too restrictive? maybe checking the commercial partner would be enough and do not block cases in which you will deliver to a different location?

Yes, you are right. I didn't think about the case of delivering in different addesses.

@AlexPForgeFlow AlexPForgeFlow changed the title [FIX] rma: _check_move_partner compare with RMA customer delivery address [FIX] rma: _check_move_partner compare with RMA commercial partner Nov 5, 2024
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LoisRForgeFlow LoisRForgeFlow changed the title [FIX] rma: _check_move_partner compare with RMA commercial partner [16.0][FIX] rma: _check_move_partner compare with RMA commercial partner Nov 5, 2024
@AaronHForgeFlow
Copy link
Contributor

Perfect! I think we can merge this

@AlexPForgeFlow AlexPForgeFlow merged commit 647e1b6 into 16.0 Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants