feat: do not fail to re-login if previous token is wrong

src/services/api.js

@@ -50,14 +50,23 @@ function Api({
    * @param {string} sessionToken
    * @returns {Promise<import('../deserializers/application-token').ApplicationToken>}
    */
-  this.deleteApplicationToken = async sessionToken =>
-    agent
-      .delete(`${this.endpoint()}/api/application-tokens`)
-      .set(HEADER_FOREST_ORIGIN, 'forest-cli')
-      .set(HEADER_CONTENT_TYPE, HEADER_CONTENT_TYPE_JSON)
-      .set(HEADER_USER_AGENT, this.userAgent)
-      .set('Authorization', `Bearer ${sessionToken}`)
-      .send();
+  this.deleteApplicationToken = async sessionToken => {
+    try {
+      await agent
+        .delete(`${this.endpoint()}/api/application-tokens`)
+        .set(HEADER_FOREST_ORIGIN, 'forest-cli')
+        .set(HEADER_CONTENT_TYPE, HEADER_CONTENT_TYPE_JSON)
+        .set(HEADER_USER_AGENT, this.userAgent)
+        .set('Authorization', `Bearer ${sessionToken}`)
+        .send();
+    } catch (error) {
+      if (error.code === 'ERR_INVALID_CHAR' && error?.message.includes('"Authorization"')) {
+        // token is wrong. silencing this error since it cannot be used for auth anyway.
+      } else {
+        throw error;
+      }
+    }
+  };
 
   this.createProject = async (config, sessionToken, project) => {
     let newProject;

test/services/api.unit.test.js

@@ -112,5 +112,20 @@ describe('services > API', () => {
       expect(superagent.set).toHaveBeenCalledWith('Authorization', 'Bearer THE-TOKEN');
       expect(superagent.send).toHaveBeenCalledWith();
     });
+    it('should silence ERR_INVALID_CHAR errors relative to auth token', async () => {
+      expect.assertions(1);
+      const { superagent, api } = setup();
+      const error = new Error('Invalid character in header content ["Authorization"]');
+      error.code = 'ERR_INVALID_CHAR';
+      superagent.send.mockRejectedValue(error);
+      await expect(api.deleteApplicationToken('THE-TOKEN')).resolves.not.toThrow();
+    });
+    it('should rethrow other errors', async () => {
+      expect.assertions(1);
+      const { superagent, api } = setup();
+      const error = new Error('Some other error');
+      superagent.send.mockRejectedValue(error);
+      await expect(api.deleteApplicationToken('THE-TOKEN')).rejects.toBe(error);
+    });
   });
 });