Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query-string-parser exception #133

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

matthv
Copy link
Member

@matthv matthv commented Oct 29, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@matthv matthv force-pushed the fix/improve-log-and-cache branch from 7e25353 to 2cbab71 Compare November 5, 2024 13:38
/**
* @codeCoverageIgnore
*/
public function __serialize(): array
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Nov 7, 2024

Code Climate has analyzed commit 0b033c1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 97.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.6%.

View more on Code Climate.

@matthv matthv force-pushed the fix/improve-log-and-cache branch from 0460b00 to b94ba81 Compare November 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants