Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrote unit tests for read #263

Merged
merged 4 commits into from
Sep 20, 2019
Merged

wrote unit tests for read #263

merged 4 commits into from
Sep 20, 2019

Conversation

saphal1998
Copy link
Contributor

Proposed changes

#194 Wrote tests

Types of changes

What types of changes does your code introduce to static food data?

  • New feature (non-breaking change which adds functionality)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Further comments

These tests don't seem to pass a few of the linting tests. Can you please look into this and let me know?

src/fileSystem.js Outdated Show resolved Hide resolved
src/fileSystem.js Outdated Show resolved Hide resolved
src/fileSystem.js Outdated Show resolved Hide resolved
src/fileSystem.js Outdated Show resolved Hide resolved
src/fileSystem.js Outdated Show resolved Hide resolved
@atherdon atherdon self-requested a review September 20, 2019 15:55
@atherdon
Copy link
Contributor

does it has that error we talked in morning?
should i take a look locally and help to fix it or i can merge it

@saphal1998
Copy link
Contributor Author

It doesn't seem like that error is still there. I think it's okay to merge now.

@atherdon
Copy link
Contributor

great

@saphal1998
Copy link
Contributor Author

Please assign me another task as well.

@atherdon
Copy link
Contributor

do you know what to do next?

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2019

Code Climate has analyzed commit 29b27a6 and detected 0 issues on this pull request.

View more on Code Climate.

@atherdon
Copy link
Contributor

got it. check this quick task
2. I find another quick task for you - move methods from writeFile into utils. but you should do it in a smart way, so nothing will go broken because of import changes

i think we don't complete it

@atherdon atherdon merged commit 5ed77c8 into Food-Static-Data:master Sep 20, 2019
@saphal1998
Copy link
Contributor Author

  1. I find another quick task for you - move methods from writeFile into utils. but you should do it in a smart way, so nothing will go broken because of import changes

Is this an issue or do you want me to create this issue? If it is an issue, can you please tag me there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants