Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual zoomableState per pager item #832

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

revonateB0T
Copy link
Collaborator

No description provided.

@revonateB0T
Copy link
Collaborator Author

FATAL EXCEPTION: main
Process: moe.tarsin.ehviewer.debug, PID: 13059
java.lang.NullPointerException
	at me.saket.telephoto.zoomable.RealZoomableState.fling-BMRW4eQ$zoomable_release(RealZoomableState.kt:502)
	at me.saket.telephoto.zoomable.ZoomableNode$onTransformStopped$1$1.invokeSuspend(Zoomable.kt:138)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
	at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:81)
	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:294)
	at android.app.ActivityThread.main(ActivityThread.java:8296)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:978)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@3a1253d, androidx.compose.runtime.BroadcastFrameClock@f23a132, StandaloneCoroutine{Cancelling}@bf50e83, AndroidUiDispatcher@e154800]

@revonateB0T
Copy link
Collaborator Author

#827 (comment)

@revonateB0T
Copy link
Collaborator Author

Maybe we should release 1.11.2 first? @FooIbar

Copy link
Owner

@FooIbar FooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But should we reset zoom when the page is off-screen?

@revonateB0T
Copy link
Collaborator Author

LGTM. But should we reset zoom when the page is off-screen?

We shouldn't, we are to implement #609

@revonateB0T revonateB0T merged commit f7259c5 into FooIbar:main Mar 17, 2024
4 checks passed
@FooIbar
Copy link
Owner

FooIbar commented Mar 17, 2024

LGTM. But should we reset zoom when the page is off-screen?

We shouldn't, we are to implement #609

IIUC that issue is asking for a global zoom level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants