Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting loggerFormat and add logger.logHttpRequests. #1289

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 22, 2024

Issue

  • The use of settings.loggerFormat is deprecated. It should be removed in a major release.
  • To support loggerFormat: none to disable HTTP logging, a new setting must be introduced with consistency with settings.logger.logSocketioMessages

Solution and steps

  • Remove settings.loggerFormat.
  • Add settings.logger.logHttpRequests.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 22, 2024
14 tasks
@LoicPoullain LoicPoullain merged commit 7b994a9 into v5-0-0 Aug 22, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the logger-format branch August 22, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

1 participant