Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run async tasks and catch and log them appropriately on failure #1276

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 3, 2024

Issue

Sometimes, we want to run an asynchronous function without awaiting for it (for example when sending a message to Slack in a request). If the function rejects an error, we want to catch and log it appropriately.

Solution and steps

  • Add an AsyncService for that purpose.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 3, 2024
8 tasks
@LoicPoullain LoicPoullain merged commit a91cdfc into v4-5-0 Aug 19, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the async-service branch August 19, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant