Eliminated LDIF read failure due to incorrect args #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ldbadd command for Sshpubkey schema specifies the sam.ldb file twice, which `ldbadd` treats as a second LDIF file, which prints an error to the output (because parsing the ldb file as LDIF fails). Also strictly speaking the options should be specified before the LDIF file(s) on the command line. The existing code worked, but this eliminates a spurious error from the output that caused me to waste time troubleshooting.
kapdap
added a commit
to kapdap/samba-domain
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ldbadd command for Sshpubkey schema specifies the sam.ldb file twice, which
ldbaddtreats as a second LDIF file, which prints an error to the output (because parsing the ldb file as LDIF fails). Also strictly speaking the options should be specified before the LDIF file(s) on the command line. The existing code worked, but this eliminates a spurious error from the output that caused me to waste time troubleshooting.