Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dcgan_mnist model #269

Merged
merged 6 commits into from Jan 18, 2021
Merged

Fix dcgan_mnist model #269

merged 6 commits into from Jan 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2021

Fixes:

  • Replace Flux.logitbinarycrossentropy with Flux.Losses.logitbinarycrossentropy
  • Take the latent_dim as input to the generator constructor

No yet fixed:

see #266

@ghost ghost mentioned this pull request Jan 17, 2021
59 tasks
vision/dcgan_mnist/dcgan_mnist.jl Outdated Show resolved Hide resolved
vision/dcgan_mnist/dcgan_mnist.jl Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 18, 2021

I removed the tanh activation of the last ConvTranspose layer and added it as an seperate layer, this works around the issue that triggered the crash. Scripts runs without problems now, output after 20 epochs seems ok.

@ghost ghost marked this pull request as ready for review January 18, 2021 18:28
@CarloLucibello
Copy link
Member

I think another manifest got caught in the update, it doesn't really matter although it will conflict with the other PR.
I'll merge whenever you say this is ready in any case

@ghost
Copy link
Author

ghost commented Jan 18, 2021

Ah yes, I missed the extra 'c' in the filename. The cdcgan models runs fine with the updated manifest.

The biggest problems with this model are solved I think, so LGTM

@CarloLucibello CarloLucibello merged commit 9aa6bef into FluxML:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants