Fix lenet_mnist model #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2021 15:38
Serializing anonymous functions fails with BSON.jl for julia 1.6 beta (JuliaIO/BSON.jl#80).
ghost
mentioned this pull request
|
Looks good, thanks! Maybe we could add proper compat bounds to each model zoo example, so that the last setup on which it was tested is more clear, without having to dig into the manifest |
darsnack
reviewed
Jan 17, 2021
|
Compat bounds sounds like a great idea! How aggressive should we be here? Is it ok to add Julia 1.5 and Flux 0.11.4 as minumum versions (these are the versions which i use for testing)? |
|
Since we don't have CI here, I would be super aggressive and use the versions in your testing configuration. |
|
I added compat entries for julia, flux and cuda. Runs without issues now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small less urgent changes which I now see I added to the commits:
see #266