Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .mb file for mnist cnn #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Akshat-mehrotra
Copy link

made a .mb file for the convolution network implementation of the MNIST recognition task. Added the updated source code file too.

made a .mb file for the convolution network implementation of the MNIST recognition task. Added the updated source code file too.
@logankilpatrick
Copy link
Member

Hey @Akshat-mehrotra the ".jl" should be combined with the existing ".jl" file rather than it being deleted.

So at the end of this Pull request, you will have one added file and then one edited file (the original ".jl" file)

@logankilpatrick
Copy link
Member

Let me know if that does not make sense or you have questions! Keep up the great work.

@Akshat-mehrotra
Copy link
Author

did the edits required

@Akshat-mehrotra
Copy link
Author

Akshat-mehrotra commented Jan 2, 2020 via email

@ChrisRackauckas
Copy link
Member

It would be nice if it was a Weave.jl .jmd fil.

@Akshat-mehrotra
Copy link
Author

Akshat-mehrotra commented Jan 2, 2020 via email

@Akshat-mehrotra
Copy link
Author

I was told to use literate.jl for the documentation.

@Akshat-mehrotra
Copy link
Author

I could change it to weave.jl. however, it might take some time as I'm out of town right now

@DhairyaLGandhi
Copy link
Member

Literate.jl should be fine, since that's what we use for generating the notebooks.

@Akshat-mehrotra
Copy link
Author

So can this PR be merged now

Added the Conv net for judge a book by its cover task
@Akshat-mehrotra
Copy link
Author

Akshat-mehrotra commented Jan 3, 2020

sorry about the commits. Accidentally pushed on the wrong branch. They have been reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants