Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MIOpen only supports activations till dimension 5 #601

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix: MIOpen only supports activations till dimension 5 #601

merged 1 commit into from
Jul 18, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jul 17, 2024 •
edited
Loading

@avik-pal avik-pal force-pushed the ap/amdgpu branch 2 times, most recently from e83ebad to 4d38e3a Compare July 17, 2024 15:54
@avik-pal avik-pal marked this pull request as ready for review July 17, 2024 15:55
@avik-pal avik-pal requested a review from pxl-th July 17, 2024 16:25
@avik-pal avik-pal mentioned this pull request Jul 17, 2024
Merged
35 tasks
pxl-th
pxl-th approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@pxl-th pxl-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!
We probably should benchmark MIOpen vs Julia implementations (in the future) to see if using MIOpen for them provides any substantial benefit.

@pxl-th pxl-th merged commit 86473fc into FluxML:master Jul 18, 2024
8 of 10 checks passed
@avik-pal avik-pal deleted the ap/amdgpu branch July 18, 2024 13:45
@avik-pal avik-pal mentioned this pull request Jul 21, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxl-th pxl-th pxl-th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avik-pal @pxl-th