Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the NewRecur functionality from Fluxperimental.jl. There are some road bumps that need to be ironed out.
scan_full
needs to be made type stable. I thought this had to do w/ the hobbits being a vector ofAny
, but when I separated out the first element and the other elements (this is where the issue is) I still see type instability when usingCthulu
. I've included the new rrule in this pull request and below it is a commented out version of the Fluxperimental.jl one. I'm not sure where else to look for type instability as the stack to call this is pretty deep. I think at some point the type instability starts coming fromZygote.ZBack
s in the stack. (I need help knowing how to iterate on this more).Recurrent
.PR Checklist