Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to documenter jl, + doc upgrades #88

Merged
merged 11 commits into from
Mar 20, 2024

Conversation

isentropic
Copy link
Contributor

@isentropic isentropic commented Feb 28, 2024

Moving to documnter jl as per zulip discussion

No deployment has been setup yet.

@isentropic
Copy link
Contributor Author

@darsnack could you give me some feedback here please? Once we are good with docs I could proceed with functionality

@darsnack
Copy link
Member

darsnack commented Mar 6, 2024

Sorry for the delay. Will take a look later today.

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general your mapping looks good. One global comment is to just replace the docs directory with Documenter instead of making a new Documenter specific directory. It looks like you have the syntax mapping figured out, but there are places you missed.

For deployment, see FluxML/ParameterSchedulers.jl#58 as a reference for a similar transition. I'll take care of the admin side of Documenter deployment (keys, etc.).

docs-documenter/src/buffering.md Outdated Show resolved Hide resolved
@isentropic
Copy link
Contributor Author

isentropic commented Mar 7, 2024

I did the changes you requested. I'm not good with yml files and github deployment, so I'm gonna leave up to you. Also currently the landing page link is broken when accessed from other repos. Not sure if it's the fault of other repos or this.

@darsnack
Copy link
Member

darsnack commented Mar 9, 2024

@isentropic I have added the deployment stuff. The only stuff left in this PR is all related to editing the .md files for the documentation.

I've added flags to the make.jl script that will warn about issues when building the docs. In particular, Pollen would auto-populate an API reference page so that every [`func`](@ref) had an associated docstring. Documenter does not do this, so we need to manually insert the docstrings.

Can you pull the latest and re-run the doc build? You'll see the warnings telling you which functions/types you need to include a docstring for. If a page exists that's an appropriate home for the missing docstring, then add it there. For example, DataAugmentation.ImageToTensor can go on the transformations.md page. If an appropriate page does not exist, then create a new .md file for it. Use your best judgement and try to get to no more warnings. Then we can rearrange together after you push these changes.

@isentropic
Copy link
Contributor Author

yeah, done

@isentropic
Copy link
Contributor Author

@darsnack any updates on this?

@CarloLucibello CarloLucibello merged commit 4459c08 into FluxML:master Mar 20, 2024
16 checks passed
@darsnack
Copy link
Member

I should have posted an update. I was reorganizing things locally for this PR. I will make those changes on a new PR now.

Thanks for doing the lion's share of the work @isentropic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants