Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNCWebview conflict patch #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

victorighalo
Copy link

There is a conflict with React Native Webview when a project has it installed is causes a conflict

Solution is to Move

  "dependencies": {
    "react-native-webview": ">=6.0.2"
  },

to

  "peerDependencies": {
    "react-native-webview": "*"
  },

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
There is a conflict with React Native Webview when a project has it installed is causes a conflict

Move 

```
  "dependencies": {
    "react-native-webview": ">=6.0.2"
  },
```

to 

```
  "peerDependencies": {
    "react-native-webview": "*"
  },
```

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Resolve RNCWebview conflict
@thecodecafe
Copy link
Contributor

Hi @victorighalo, this is great, we currently have the library only tested and verified to work correctly on WebView 6.0.2 and above, an adjustment you may need to make is to change the version required to the following.

  "peerDependencies": {
    "react-native-webview": ">=6.0.2"
  },

Once that's done we should be good to go.

@stephenson080
Copy link

yeah this have a conflict with the root react-native-webview package. please approve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants