-
Notifications
You must be signed in to change notification settings - Fork 12
Bump dependencies #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make sure the CI is testing the exact same version we are releasing to the public. Lock the dependencies to make error reproduction more reliable.
4c809ff
to
521221c
Compare
aemelyanovff
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I love the test!
All my comments are nits and entirely optional, feel free to ignore them.
4a14a5d
to
2caef48
Compare
The idea is to test exporting code using Dart test runner, it will make it easier to write cross platform integration tests for the various command line options.
This exception catch block was silently ignoring error such as 'rate limited'.
2caef48
to
df95c7f
Compare
Add a test that will export and build using our various flags and check if the command is behaving as expected on all the platforms we support.
Build tests are going to take over 10 min
df95c7f
to
fcd0b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies and add integration tests.
Also checking-in the pubspec.lock to make sure we test the same version that we ship when there is a problem.