Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pressEnterAdaptive and pressNumpadEnterAdaptive IME calls #21

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix pressEnterAdaptive and pressNumpadEnterAdaptive IME calls #21

merged 1 commit into from
Oct 4, 2023

Conversation

angelosilvestre
Copy link
Collaborator

Both pressEnterAdaptive and pressNumpadEnterAdaptive aren't passing the IME getter to the *WithIme versions, causing an exception.

This PR fixes the bug.

matthew-carroll
matthew-carroll approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit c573b22 into Flutter-Bounty-Hunters:main Oct 4, 2023
1 check passed
@angelosilvestre angelosilvestre deleted the adaptive_bug branch October 4, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-carroll matthew-carroll matthew-carroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelosilvestre @matthew-carroll