-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update NecroValley #1972
update NecroValley #1972
Conversation
confirming |
@@ -23,7 +23,7 @@ function c83764718.target(e,tp,eg,ep,ev,re,r,rp,chk,chkc) | |||
end | |||
function c83764718.activate(e,tp,eg,ep,ev,re,r,rp) | |||
local tc=Duel.GetFirstTarget() | |||
if tc:IsRelateToEffect(e) and aux.NecroValleyFilter()(tc) then | |||
if tc:IsRelateToEffect(e) and e:GetHandler():IsHasEffect(EFFECT_NECRO_VALLEY_CHECK) and aux.NecroValleyFilter()(tc) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and e:GetHandler() is related to e
Maybe getting the current effect handler and NecroValley player effect in NecroValleyFilter
and check immunity will work? I know card immune to player effect can be weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EFFECT_NECRO_VALLEY
for monsters: The monster is protected by Necrovalley.
for players: The Graveyard of the player is protected by Necrovalley.
I think this check should use a different effect code.
@mercury233 |
I don't think so but I don't know why |
Auxiliary.NecroValleyFilter() 此處IsHasEffect(EFFECT_NECRO_VALLEY)的定義應該是: 如果我們要檢查【這張卡是否會被王谷的效果無效】 |
@mercury233
Problem
#1860
Solution
EFFECT_NECRO_VALLEY_CHECK
Check if the activating card is affected by NecroValley.
Reference
https://ocg-rule.readthedocs.io/zh_CN/latest/c04/%E7%8E%8B%E5%AE%B6%E9%95%BF%E7%9C%A0%E4%B9%8B%E8%B0%B7.html#id4