Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port DSP code to C++ to address performance penalty #1469

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Conversation

derselbst
Copy link
Member

I found that after merging #1444 a small performance penalty was introduced. Looking at VTune's profiling report (see below) showed the outer if clause of fluid_iir_filter_apply being pretty busy. I assume this is because the calling code in fluid_rvoice_dsp.c invokes that function twice, once with the custom filter typically being disabled, and the regular low pass filter being enabled. Before merging #1444 this was done once per voice. Now it's done for every single sample, which apparently hurts branch prediction and possibly also instruction caching.

To address this, I ported the DSP code to C++98, which allows me to use templating to generate multiple versions of the DSP code. One of them e.g. never attempts to use the custom IIR filter in the DSP loop if it's unused for that voice. Also whether or not to construct a 24bit sample has been templatified.

In addition, most of the IIR filter code was moved to the header, allowing the compiler to inline it.

With these changes, our testsuite make check_manual now finishes up 7 seconds faster for me.


Profiling before this PR (at rev e57360d):

Screenshot_20250112_121227

Screenshot_20250112_121412

Profiling after this PR, fluid_iir_filter_apply is no longer that busy.

Screenshot_20250112_123611

@derselbst derselbst added this to the 2.4 milestone Jan 12, 2025
@derselbst derselbst force-pushed the dsp-cpp branch 2 times, most recently from ed6283d to 9e08718 Compare January 25, 2025 10:20
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.1% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@derselbst derselbst merged commit 66e5f2e into master Jan 25, 2025
62 of 79 checks passed
@derselbst derselbst deleted the dsp-cpp branch January 25, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant