Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace VERSIONINFO resource cmake macro #1449

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Replace VERSIONINFO resource cmake macro #1449

merged 1 commit into from
Dec 10, 2024

Conversation

pedrolcl
Copy link
Contributor

@pedrolcl pedrolcl commented Dec 8, 2024

Fix #1448

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@derselbst derselbst added this to the 2.4 milestone Dec 10, 2024
derselbst
derselbst approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derselbst derselbst merged commit 3eaf722 into FluidSynth:master Dec 10, 2024
51 of 55 checks passed
@pedrolcl pedrolcl deleted the fix_1448 branch December 10, 2024 21:50
DominusExult added a commit to DominusExult/fluidsynth-sans-glib that referenced this pull request Dec 27, 2024
@DominusExult
Merge branch 'master' into sans_glib
5950007 
* master: (66 commits)
  Add portamento test files
  Restore discovery of libsndfile on Ubuntu (FluidSynth#1454)
  Fix crash on startup when there are no MIDI devices  (FluidSynth#1447)
  Replace VERSIONINFO resource cmake macro (FluidSynth#1449)
  Fix filter processing order in DSP chain (FluidSynth#1444)
  Render the nervous filter with additional soundfonts
  Add Christian's SF2 spec test to regression tests
  Bump testdata ref
  Migrate test files from LFS to submodule
  Delete test files from Git LFS
  Bump to 2.4.1
  Smooth linear filter parameter change (FluidSynth#1432)
  Reenable AWE32 NRPN 23 and 24 (FluidSynth#1430)
  indentation issue
  Disable chorus for Uplift - it's too noisy in the middle part
  Add Klerg's renderings of Altitude and Uplift
  updated cmake build system * debug output for libsndfile, quieter output for pulseaudio * enhanced build summary report * revised building win32 binaries without unicode support
  add cmake output for sndfile issues
  Fix CI builds (FluidSynth#1435)
  Add test files for AWE32 NRPN (FluidSynth#1434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derselbst derselbst derselbst approved these changes

Assignees
No one assigned
Labels
buildsystem
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

Build failure when processing VersionResource.rc
2 participants
@pedrolcl @derselbst