[MIRROR] [MODULAR] Add: Voice Actor Quirk #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Voice Actor quirk, action, and prefs * Fix vet requirement and gain_text * Fix missing apply_to_human() implementations * Fix typos * Remove medical record text from voice actor quirk * Fix voice actor pref validation and speaker list generation * Add quirk_constant_data for voice actor quirk * Add extra vars for original voice * Fix pref validation, fix action isAvailable * Refine quirk description * Fix activation bug, fix background icon, treeshake vars, add balloon alert and chat messages * Fix argument * Simplify json file loading * Cleaning up, fix action bugs, fix button icon bug * Update modular_nova/modules/voice_actor_quirk/code/alter_voice_action.dm * Update modular_nova/modules/voice_actor_quirk/code/alter_voice_action.dm --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4529
About The Pull Request
This PR adds the Voice Actor quirk, which allows players to swap between their primary TTS voice and a secondary TTS voice.
The quirk has two prefs, one for the secondary voice style and one for its pitch.
Granular Change List:
voice_actor_quirkmodule, which contains datums for the quirk, action, and preferences.interfaces\PreferencesMenu\preferences\features\character_preferences\nova\voice_actor.tsx/datum/quirk/voice_actorwhich grants action/datum/action/innate/alter_voiceto the quirk holder./datum/action/innate/alter_voiceis only available/usable if TTS is enabled, however the quirk remains visible.How This Contributes To The Nova Sector Roleplay Experience
Provides a more interesting way to use TTS voices! I can imagine many different types of characters who would use this quirk.
Proof of Testing
Screenshots/Videos
Changelog
🆑 A.C.M.O.
add: Added the Voice Actor Quirk to Character Preferences.
/:cl: