[MIRROR] Add Sensitive Hearing: Teshari ears for everyone #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Sensitive Hearing quirk Add sensitive ears organ for quirk users Fix Teshari hearing being broken without admin intervention when ears are removed while teshari hearing is active Add conditional flavor text changes to Teshari hearing for Sensitive Hearing users * I'm not doing that lol * neocloudy teaches me why ternary exists Reformatted comments / add one explaining why the ternary * dmdoc-ified the comments but for real this time * MORE COMMENT TOUCHING * Update code/controllers/subsystem/processing/quirks.dm --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4754
About The Pull Request
This PR adds the Sensitive Hearing quirk which, in exchange for one of your positive quirk slots and slightly increased vulnerability to hearing damage (more than Teshari), allows you to toggle on/off hearing whispers with included examine, activation, and deactivation flavor text. Coincidentally, it also fixes Teshari hearing breaking (admin variable editing required) if you lose the ears while Teshari hearing is active.
Q: Where did this come from? Why?
A: https://discord.com/channels/1171566433923239977/1327758325441368154
How This Contributes To The Nova Sector Roleplay Experience
I have more than one character that is both NOT a Teshari and IS flavored to have excellent hearing, but the only way to mechanically get that would be with researched implants (which also cannot be toggled on/off) or by making them a Teshari (no).
Also, it fixes a niche bug that has probably screwed somebody at some point.
Proof of Testing
Thoroughly tested, which is coincidentally how I discovered the aforementioned/fixed bug. See below.
Screenshots/Videos
Changelog
🆑 DBGit42
add: Added Sensitive Hearing positive quirk
fix: Teshari hearing no longer breaks if you lose your ears while it's active
/:cl: