[MIRROR] Makes colony appliances show descriptions in the rapid construction fabricator. #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abricator. (#4418) Makes colony appliances show descriptions in the colony lathe. also actually a whole refactor of how the underlying system for flatpack descs works
…ruction fabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4418
About The Pull Request
This PR makes colony appliances show descriptions in the colony lathe's menus. Yeah.
The title soooomewhat omits the fact that this is through a minor refactor of how descriptions of flatpacked machines works, now inheriting descriptions with what the code style guide now recommends. In practice, this means flatpacked machines can now have different descriptions from the machines they deploy while only having to touch the desc variable. Also the wind turbine showing the wrong description is fixed and a random useless variable was removed (it got overwritten only two lines down and was redundant to begin with because its the same value as parent).
How This Contributes To The Nova Sector Roleplay Experience
It's neat to know what a CO2 Scrubber does before you print it.
Proof of Testing
Screenshots/Videos
Changelog
🆑 CRITAWAKETS
fix: Colony appliances now show their description in the rapid construction fabricator's menus.
fix: Wind turbines no longer pretend they're rapid construction fabricators, a way cooler machine than they'll ever be.
refactor: Flatpacked machines now copy descriptions in a different and cleaner way, allowing for custom descriptions between the flatpack and the machine it deploys.
/:cl: