Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Make rings fire and lava proof #5021

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#4383

About The Pull Request

Makes rings and any childs of it (to future proof it) fire and lava proof, in a modular file out of the way of things.

How This Contributes To The Nova Sector Roleplay Experience

Requested in: https://discord.com/channels/1171566433923239977/1212990135927570493/1212990135927570493

They are small objects with no mechanical advantage, which in my opinion should be accesories instead as gloves are a mechanical important aspect of the game, and tend to be metal made, which makes it weird how flamable they proved. Added lava proof since it has little impact for anything and might as well prevent a terrible accident that might impact negatively, for a really minor impact on disbelief.

Proof of Testing

Screenshots/Videos

image

Changelog

🆑 OrbisAnima
qol: made rings fire proof
/:cl:

OrbisAnima and others added 2 commits September 11, 2024 23:31
* make rings fire and lava proof

* Update modular_nova/modules/modular_items/code/ring.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
@FeenieRU FeenieRU merged commit 9693406 into master Sep 11, 2024
30 checks passed
@Iajret Iajret deleted the upstream-mirror-4383 branch September 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants