Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] New shove sound #4211

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[MIRROR] New shove sound #4211

merged 1 commit into from
Jul 3, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#3475
Original PR: tgstation/tgstation#84555

About The Pull Request

New more meaty shove sound effects to give better feedback. Made using sound effects already in-game files (pillowhit and thudwoosh)

shove.mp4

Used in:

  • Random scary maints sounds
  • Ling tentacle hitting someone
  • Wrestling off slimes
  • Shoving (duh)

Why It's Good For The Game

Shoving shares the same sound with two other intents - Grabbing and Hugging.
This makes it more different from those two and gives better feedback. Shoving someone wouldn't just make a "woosh" as you apply hefty kinetic force to their body, so slight punchiness to it is good.
After brawlening has been merged shoves have become even more dangerous, even if not against the wall.

Fights should sound more violent.

Changelog

🆑 DrDiasyl aka DrTuxedo
sound: Shoves now produce more meaty sound!
/:cl:

* New shove sound (#84555)

## About The Pull Request

New more meaty shove sound effects to give better feedback. Made using
sound effects already in-game files (pillowhit and thudwoosh)


https://github.com/tgstation/tgstation/assets/42353186/7f5d516e-36e5-4d7d-8272-a24c842e962c

Used in:
- Random scary maints sounds
- Ling tentacle hitting someone
- Wrestling off slimes
- Shoving (duh)
## Why It's Good For The Game

Shoving shares the same sound with two other intents - Grabbing and
Hugging.
This makes it more different from those two and gives better feedback.
Shoving someone wouldn't just make a "woosh" as you apply hefty kinetic
force to their body, so slight punchiness to it is good.
After brawlening has been merged shoves have become even more dangerous,
even if not against the wall.

Fights should sound more violent.
## Changelog
:cl: DrDiasyl aka DrTuxedo
sound: Shoves now produce more meaty sound!
/:cl:

* New shove sound

---------

Co-authored-by: DrTuxedo <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
@Iajret Iajret merged commit 45535d4 into master Jul 3, 2024
28 checks passed
@Iajret Iajret deleted the upstream-mirror-3475 branch July 3, 2024 17:20
AnywayFarus added a commit that referenced this pull request Jul 3, 2024
Iajret pushed a commit that referenced this pull request Aug 7, 2024
…the Bar Lounge or the Delta Service Promenade. (#4211)
FeenieRU pushed a commit that referenced this pull request Aug 7, 2024
…atons in the Bar Lounge or the Delta Service Promenade. (#4895)

* [MODULAR] Fixes Service Guards not being able to use their batons in the Bar Lounge or the Delta Service Promenade. (#4211)

* [MIRROR] [MODULAR] Fixes Service Guards not being able to use their batons in the Bar Lounge or the Delta Service Promenade.

---------

Co-authored-by: Iamgoofball <[email protected]>
Co-authored-by: StealsThePRs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants