[MIRROR] Humanizing monkeys removes undergarments #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Humanizing monkeys removes undergarments (#84439) ## About The Pull Request Humanizing a monkey doesn't result in someone with trans thigh-highs and a bra ## Why It's Good For The Game It is kinda weird and bad for immersion. Humans can just get it back from dressers anyways. ## Changelog :cl: Melbert add: Humanizing a monkey removes undergarments such as socks /:cl: * Humanizing monkeys removes undergarments --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jun 30, 2024
Iajret
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Attempting to fix search_object hard dels (#85394) ## About The Pull Request  These were coming up often, had a hunch that the callback may have been hanging their refs. It seems to be true from my testing, they should be passing GLOBAL_PROC as the `object` arg, not `src`, since qdel is not a `search_object` proc. (Thanks Melbert for noticing that detail!) Also just tidies up the code a bit, adding checks to prevent redundant qdel calls and preventing a potential race condition with qdeleted atoms. ## Why It's Good For The Game Hard dels here in particular have potential to cause significant lag and issues. ## Changelog Not player-facing really * Attempting to fix search_object hard dels --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
FeenieRU
pushed a commit
that referenced
this pull request
Jul 31, 2024
* [MIRROR] Attempting to fix search_object hard dels [MDB IGNORE] (#4140) * Attempting to fix search_object hard dels (#85394) ## About The Pull Request  These were coming up often, had a hunch that the callback may have been hanging their refs. It seems to be true from my testing, they should be passing GLOBAL_PROC as the `object` arg, not `src`, since qdel is not a `search_object` proc. (Thanks Melbert for noticing that detail!) Also just tidies up the code a bit, adding checks to prevent redundant qdel calls and preventing a potential race condition with qdeleted atoms. ## Why It's Good For The Game Hard dels here in particular have potential to cause significant lag and issues. ## Changelog Not player-facing really * Attempting to fix search_object hard dels --------- Co-authored-by: Bloop <[email protected]> Co-authored-by: NovaBot13 <[email protected]> * [MIRROR] Attempting to fix search_object hard dels --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Bloop <[email protected]> Co-authored-by: NovaBot13 <[email protected]> Co-authored-by: StealsThePRs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#3395
Original PR: tgstation/tgstation#84439
About The Pull Request
Humanizing a monkey doesn't result in someone with trans thigh-highs and a bra
Why It's Good For The Game
It is kinda weird and bad for immersion. Humans can just get it back from dressers anyways.
Changelog
🆑 Melbert
add: Humanizing a monkey removes undergarments such as socks
/:cl: