[MIRROR] Blood filter surgery update #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Blood filter surgery update (#84431) ## About The Pull Request Updates the blood filter surgery step to be less chat and sound spammy, only going 'ping' when it's completed filtering blood as the text message implies. During the filter running process instead the sound is a softer hum. ## Why It's Good For The Game We have progress bars above our head and cogwheels to other viewers. We don't need two text log lines and a 'ping' every time it runs the filter loop. It should only say completed and ping when it's actually completed. ## Changelog :cl: LT3 code: Blood filter only pings and says finished when it's actually finished /:cl: * Blood filter surgery update --------- Co-authored-by: lessthanthree <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jun 30, 2024
Iajret
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Fixes AI Mech Control GBJing the AI (#85354) ## About The Pull Request So when an AI entered a mech it wasnt considered an occupant it was just there, so it didnt get controls or UI or anything (cuz the add_control_flags proc only gives the controls to mobs in the occupants list) it was just there stuck unable to move or do anything really. I put this proc in so the AI can do stuff now. I dunno if this is cleanest of fixes but it's 5am and in my testing it makes it go from not working to working so I'm claiming it is good enough (tm) I cant really convey how it works in image form so I will go over the steps I did to implement this fix: On master, mess about with AI dominating mechs or controlling mechs with a beacon. See how none of the AI buttons appear, WASD stops moving the camera around. The mouse changes to the correct mech style but nothing else works. Call a bunch of procs on the AI to see what does something, add_occupant with the AI marked as the only argument works and makes everything function as intended. Tell the code to do that. ## Why It's Good For The Game I don't like mechs but I know some people do so it's cool for those people that it works :) ## Changelog :cl: fix: AI mech control beacons and malf AI dominate mech work again. /:cl: * Fixes AI Mech Control GBJing the AI --------- Co-authored-by: Jackraxxus <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
FeenieRU
pushed a commit
that referenced
this pull request
Jul 31, 2024
* [MIRROR] Fixes AI Mech Control GBJing the AI [MDB IGNORE] (#4135) * Fixes AI Mech Control GBJing the AI (#85354) ## About The Pull Request So when an AI entered a mech it wasnt considered an occupant it was just there, so it didnt get controls or UI or anything (cuz the add_control_flags proc only gives the controls to mobs in the occupants list) it was just there stuck unable to move or do anything really. I put this proc in so the AI can do stuff now. I dunno if this is cleanest of fixes but it's 5am and in my testing it makes it go from not working to working so I'm claiming it is good enough (tm) I cant really convey how it works in image form so I will go over the steps I did to implement this fix: On master, mess about with AI dominating mechs or controlling mechs with a beacon. See how none of the AI buttons appear, WASD stops moving the camera around. The mouse changes to the correct mech style but nothing else works. Call a bunch of procs on the AI to see what does something, add_occupant with the AI marked as the only argument works and makes everything function as intended. Tell the code to do that. ## Why It's Good For The Game I don't like mechs but I know some people do so it's cool for those people that it works :) ## Changelog :cl: fix: AI mech control beacons and malf AI dominate mech work again. /:cl: * Fixes AI Mech Control GBJing the AI --------- Co-authored-by: Jackraxxus <[email protected]> Co-authored-by: NovaBot13 <[email protected]> * [MIRROR] Fixes AI Mech Control GBJing the AI --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Jackraxxus <[email protected]> Co-authored-by: NovaBot13 <[email protected]> Co-authored-by: StealsThePRs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#3393
Original PR: tgstation/tgstation#84431
About The Pull Request
Updates the blood filter surgery step to be less chat and sound spammy, only going 'ping' when it's completed filtering blood as the text message implies. During the filter running process instead the sound is a softer hum.
Why It's Good For The Game
We have progress bars above our head and cogwheels to other viewers. We don't need two text log lines and a 'ping' every time it runs the filter loop. It should only say completed and ping when it's actually completed.
Changelog
🆑 LT3
code: Blood filter only pings and says finished when it's actually finished
/:cl: