[MIRROR] Fixes critical storage issues #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [NO GBP] Fixes critical storage issues (#84449) Closes #84447 Closes #84445 Fixes incorrect assoc list deletion, storage deletion order and some math oopsies :cl: fix: Storage no longer deletes all of its viewers upon being deleted fix: Storage UI now renders properly /:cl: * [NO GBP] Fixes critical storage issues --------- Co-authored-by: SmArtKar <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Steals-The-PRs
added
Mirroring conflict
AnywayFarus
added a commit
that referenced
this pull request
Jun 29, 2024
Iajret
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Scanner gate fixes * conflict --------- Co-authored-by: lessthanthree <[email protected]> Co-authored-by: Fluffles <[email protected]>
FeenieRU
pushed a commit
that referenced
this pull request
Aug 1, 2024
* [MIRROR] Scanner gate fixes [MDB IGNORE] (#4128) * Scanner gate fixes * conflict --------- Co-authored-by: lessthanthree <[email protected]> Co-authored-by: Fluffles <[email protected]> * [MIRROR] Scanner gate fixes --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: lessthanthree <[email protected]> Co-authored-by: Fluffles <[email protected]> Co-authored-by: StealsThePRs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#3375
Original PR: tgstation/tgstation#84449
About The Pull Request
Closes #84447
Closes #84445
Fixes incorrect assoc list deletion, storage deletion order and some math oopsies
Changelog
🆑 SmArtKar
fix: Storage no longer deletes all of its viewers upon being deleted
fix: Storage UI now renders properly
/:cl: