Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Ports an EMP Effect on the Crew Monitor #3431

Merged
merged 1 commit into from
May 22, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#2603

About The Pull Request

Someone showed me Bubberstation/Bubberstation#801 and I thought that's pretty neat, and makes sense your sensors would start sending bad data back instead of just going off.

How This Contributes To The Nova Sector Roleplay Experience

It helps raise alarm that someone got EMP'd and may be stuck somewhere for a while because of it, at the same time it doesnt ruin an antags EMP as the location gets completely scrambled. If your suit's malfunctioning, let it send bad and unreliable data back.

Proof of Testing

Screenshots/Videos

image

image

Changelog

🆑 Zergspower
add: EMP's on suit sensors now show flavor on the crew console
/:cl:

* push

* no more beeping : (

* Apply suggestions from code review

Co-authored-by: Bloop <[email protected]>

* Update _under.dm

* Update _under.dm

* Update code/modules/clothing/under/_under.dm

rogue space

---------

Co-authored-by: Bloop <[email protected]>
@ReezeBL ReezeBL merged commit f72a93e into master May 22, 2024
27 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-2603 branch May 22, 2024 06:38
AnywayFarus added a commit that referenced this pull request May 22, 2024
Iajret pushed a commit that referenced this pull request Jul 1, 2024
…3431)

* Makes extinguisher  has_reagent check subtypes (#84403)

## About The Pull Request
Fixes #84140
## Why It's Good For The Game
I like spraying cultists with the power of jesus christ
## Changelog
:cl: lorwp
fix: extinguishers now can be filled with subtypes of water again
(Namely, holy water)
/:cl:

* Makes extinguisher  has_reagent check subtypes

---------

Co-authored-by: Lorwp <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants