Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Removes night vision quirk #3425

Merged
merged 1 commit into from
May 21, 2024
Merged

[MIRROR] Removes night vision quirk #3425

merged 1 commit into from
May 21, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2599
Original PR: tgstation/tgstation#83356

About The Pull Request

This pr removes the quirk night vision from being selectable

Why It's Good For The Game

Since the night vision rework this gives instead of the 3 tiles around you full soft vision in the darkness
Heres 2 screenshots to compare the difference.

This is what people without night vision see.
image

This is what people with night vision see.
image

Night vision does not define a character and is 100% client side.
this also turns antags like nightmares that hide in the shadows less scary and just make the envoirement boring when it comes to combat darkness vs light has 0 adventages because majority of the people run night vision antags who break lights to rely on this adventage just end up wasting time because everyone has inbuilt night vision

Changelog

* Removes night vision quirk

* Modulariuzes Nightvision

* CI is going to complain that TG removed this

---------

Co-authored-by: Nick <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
@Iajret Iajret merged commit 712a756 into master May 21, 2024
26 of 27 checks passed
@Iajret Iajret deleted the upstream-mirror-2599 branch May 21, 2024 20:28
Iajret pushed a commit that referenced this pull request Jul 1, 2024
…IGNORE] (#3425)

* Bounty Hunters have personalized arrival announcements (#84148)

## About The Pull Request

Fugitive Hunters now have a personalized message for when they arrive,
replacing the generic "Unidentified ship detected near the station"
message.

Spacepol:


![image](https://github.com/tgstation/tgstation/assets/28870487/d00fef5b-f2eb-4dea-baa6-f102546b11b9)

Russians:


![image](https://github.com/tgstation/tgstation/assets/28870487/74aa6f82-5741-4bc8-81be-18da75d35697)

Bounty Hunters:


![image](https://github.com/tgstation/tgstation/assets/28870487/015d4741-5367-4d98-8e10-de513c4654ce)

Psykers:


![image](https://github.com/tgstation/tgstation/assets/28870487/23754b72-7932-42d6-a3d8-2335e7238c0d)

I swear, someday I'll datumize these backstories like we did for
pirates. Maybe after this PR is resolved.
## Why It's Good For The Game

Added flavor is nice. It also gives the crew a cue on how to react to
the hunters, seeing as some hunters are received far more cooperatively
than others (looking at you, SpacePol).

The generic message used to be a fakeout for pirates, but now that THEY
have personalized messages, it doesn't really need to be like that
anymore.
## Changelog
:cl:
add: Bounty Hunter teams now have personalized announcements for when
they are spawned in.
/:cl:

* Bounty Hunters have personalized arrival announcements

---------

Co-authored-by: Rhials <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants