[MIRROR] Fixes deathmatch modifier menu #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes deathmatch modifier menu (#83335) ## About The Pull Request Title. I dont understand this code very well, but I feel like passing in a static FALSE into mod_menu_open isnt intentional? Also, I have a feeling this ternary was flipped, since non-hosts would get getting the lsit of modifiers while the host gets nothing. ## Why It's Good For The Game BUGS BAD ## Changelog :cl: fix: The deathmatch modifier menu works now /:cl: * Fixes deathmatch modifier menu --------- Co-authored-by: nikothedude <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
May 21, 2024
Iajret
pushed a commit
that referenced
this pull request
Jul 1, 2024
… [MDB IGNORE] (#3424) * Heretic spell invocations now use one dead language per path (#84068) ## About The Pull Request Heretic invocations are now translations of their spell name/older invocation into a dead language, one per path. Base spells use Ancient Greek, because it's ancient and sounds cool. Ash spells use Old Norse, because both myths are linked to ash. Flesh spells use Latin, as a nod to Roman hedonism. Void spells use Pali, as a nod to Buddhism and its philosophy of nothingness. Blade spells use Aramaic, due to its relation with the city of Damascus. Rust spells use Old Slavic, which was recommended to me by a slavic linguist friend of mine but the jerk didn't say why. Cosmos spells use Sumerian, as both are 'primordial' Lock spells use Egyptian, as both relate to secrets and mysteries. Moon spells use Ancient Hebrew, due to the culture's strong relation with the moon. These language picks are mostly just to be cute. The main intention of the PR is to replace the awful convention of 'spell name but the vowels are replaced with an apostrophe for some reason'. The secondary intention is to have each path's spell invocations be visibly different from eachother, and from wizardly spells, befitting their status as being from different entities. ## Why It's Good For The Game Our current spell invocations are an affront, not just to the eyes, but the ears as well with TTS garbling all the invocations because they hide every vowel. They're also conceptually lame. Giving each path a unique invocation language or pattern will go some ways to distinguishing each of them in active gameplay and in flavor. If someone wants to add new spells they can just make some shit up that sounds similar to the spell invocations I translated - historical accuracy isn't really the focus here more than getting the 'feel' of each language across. ## Changelog :cl: spellcheck: Heretic spell invocations now use one dead language per path. Altered a few invocation types. /:cl: --------- Co-authored-by: dj-34 <[email protected]> * Heretic spell invocations now use one dead language per path --------- Co-authored-by: carlarctg <[email protected]> Co-authored-by: dj-34 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2600
Original PR: tgstation/tgstation#83335
About The Pull Request
Title.
I dont understand this code very well, but I feel like passing in a static FALSE into mod_menu_open isnt intentional? Also, I have a feeling this ternary was flipped, since non-hosts would get getting the lsit of modifiers while the host gets nothing.
Why It's Good For The Game
BUGS BAD
Changelog
🆑 nikothedude
fix: The deathmatch modifier menu works now
/:cl: