[MIRROR] Fixing cell power usage (Part 1) #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing cell power usage (Part 1) * Conflicts * woops --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-1627
AnywayFarus
added a commit
that referenced
this pull request
Mar 28, 2024
Iajret
pushed a commit
that referenced
this pull request
May 21, 2024
* Makes monkey powder reaction instant (#83354) ## About The Pull Request - Fixes #83347 This issue title is misleading because the actual problem is with the monkey reaction Because this reaction is currently not instant it will only require `CHEMICAL_QUANTIZATION_LEVEL`(0.0001)u of reagents to be present for the reaction to occur. This means even though the actual requirements are 50u power & 1u water in reality you only need 0.005u(50 * 0.0001) powder & 0.0001u(1 * 0.0001) water for the reaction to occur. This is expected behaviour for non instant reactions because we still want reactions to occur but yield less products when less required reagent amounts are present but it's not ideal for monkey reactions ## Changelog :cl: fix: Monkey power reactions are instant and won't occur when exact reagent requirements (50u power & 1u water) or above aren't met. Stops players from cheesing monkeys from plumbing factories /:cl: * Makes monkey powder reaction instant --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1627
Original PR: tgstation/tgstation#82197
About The Pull Request
Yeah i am not about to create 30 different PR's to address 1 issue at a time. The changes are small enough to be grouped together in bulk.
This fixes the following issues specified in #82196
Changelog
🆑 SyncIt21
fix: Fixed cell energy usage for a bunch of stuff(Part 1). See PR 82197 for details
/:cl: