Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Space dragons are no longer acceptable dna for the omnitrixbelt #2578

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1650
Original PR: tgstation/tgstation#82157

About The Pull Request

We've had people able to transform into space dragons with no limitations for quite a while now. Whenever dragons are killed multiple people will rush the polymorph belt and become space dragons. this version of the space dragon faces none of the limitations of the regular antagonist, such as not needing to place portals.

Why It's Good For The Game

Crewmembers should not be able to become space dragons en masse after doing a single anom core test. This isn't healthy and leads to headaches for admins and players who aren't a part of the dragon spam.

Changelog

🆑 carshalash
balance: The polymorph belt will no longer register space dragons as acceptable DNA.
/:cl:

…elt (#1650)

* Space dragons are no longer acceptable dna for the omnitrixbelt (#82157)

## About The Pull Request

We've had people able to transform into space dragons with no
limitations for quite a while now. Whenever dragons are killed multiple
people will rush the polymorph belt and become space dragons. this
version of the space dragon faces none of the limitations of the regular
antagonist, such as not needing to place portals.

## Why It's Good For The Game

Crewmembers should not be able to become space dragons en masse after
doing a single anom core test. This isn't healthy and leads to headaches
for admins and players who aren't a part of the dragon spam.

## Changelog

:cl:
balance: The polymorph belt will no longer register space dragons as
acceptable DNA.
/:cl:

* Space dragons are no longer acceptable dna for the omnitrixbelt

---------

Co-authored-by: carshalash <[email protected]>
@ReezeBL ReezeBL merged commit 910399d into master Mar 27, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1650 branch March 27, 2024 10:02
AnywayFarus added a commit that referenced this pull request Mar 27, 2024
Iajret pushed a commit that referenced this pull request May 20, 2024
…from all sides. (#2578)

* Ore vents now have countermeasures against walling them off from all sides. (#83295)

## About The Pull Request

This PR fixes some balance and practicality issues with the spawner
component that has affected vent mining and the associated wave defense.

* The turf_peel() proc now checks to see if it's pulling no turf from
the inside or outside of it's peel, in which case it now has a default
case where it returns it's center turf instead.
* As a consequence of this, the center turf is where mobs will spawn if
an ore vent is unable to find any space where it can spawn any new
hostile mobs.

Upon testing this, it worked fairly well, but ultimately node drones
were capable of tanking enough hits for long enough that typically they
could still survive a small vent's onslaught. As a precaution, I've made
two additional changes.

* Node drones have had their maximum health dropped slightly, from 500
health to 300 health.
* As a secondary precaution, if a spawner using the turf peel method
cannot spawn correctly, it will send a signal, which ore vents are now
registered to. When called on an ore vent, it has new behavior to clear
the offending nearby turfs and create a pathway to allow nearby mobs to
get access to the vent.
* (**This is an explosion**.)

## Why It's Good For The Game

Fixes an unreported on the repo but repeatedly pinged issue regarding
ore vent waves where players could often wall off or blockoff an ore
vent in such a way that it allows vents to be functionally immortal by
quickly walling off the vent using sandstone doors. This should help to
prevent players cheesing the intended gameplay mechanic, as well as keep
up the challenge to arcmining wave defense without some additional
nuance.

I may have gone a little overboard with the health tweaks as well, but
considering that even with the explosions, I was able to survive the
repeated explosions on the vent, I think this should work quite well all
things considered. Still, open to feedback there.

## Changelog

:cl:
balance: Ore vents, if blocked off from all four sides while being
defended, now cause a mild gas explosion, resulting in a mild dissuasive
explosion.
fix: NODE drones spawned from ore vent defense have lower maximum
health.
/:cl:

* Ore vents now have countermeasures against walling them off from all sides.

---------

Co-authored-by: ArcaneMusic <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants