Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Clean up examine panel spans #2567

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[MIRROR] Clean up examine panel spans #2567

merged 2 commits into from
Mar 25, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1616

About The Pull Request

Over the years as various features have been added, people have generally thrown a . += wherever required without taking into account the other examine spans that may be impacted, or if a closing span tag is required.

How This Contributes To The Nova Sector Roleplay Experience

Cleans up the css/span tags of the non-TG examine fields for better consistency and readability.

Proof of Testing

Screenshots/Videos Before (Left) / After (Right)

image

image

Changelog

🆑 LT3
spellcheck: Minor improvements to examine panel CSS
/:cl:

* update examine panel spans

* update nif examine text
@Iajret Iajret enabled auto-merge (squash) March 25, 2024 20:42
@Iajret Iajret merged commit 39de798 into master Mar 25, 2024
23 checks passed
AnywayFarus added a commit that referenced this pull request Mar 25, 2024
@Iajret Iajret deleted the upstream-mirror-1616 branch March 26, 2024 20:56
Iajret pushed a commit that referenced this pull request May 20, 2024
…in no longer rapidly loses power (#2567)

* Unreverts the fixes from #82713; the mining station once again no longer rapidly loses power (#83319)

## About The Pull Request

#82537 unfortunately reverted my fixes in #82713 because of how old that
PR was when it was merged. So this restores those fixes.

## Why It's Good For The Game

The bane of map prs that stay up for a really long time is that this
happens a lot more than you would think.

## Changelog
:cl:
fix: Miners can actually access and fix their engineering issues on the
lavaland base via the engineering section of the base. AGAIN.
fix: The gulag SMES unit is no longer needlessly draining the entire
power grid of the main mining base. AGAIN.
/:cl:

* Unreverts the fixes from #82713; the mining station once again no longer rapidly loses power

---------

Co-authored-by: necromanceranne <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants