Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[MIRROR] Fix some wonky anchored_tabletop_offset rendering (#4831)
* [MIRROR] Fix some wonky anchored_tabletop_offset rendering [MDB IGNORE] (#4137) * Fix some wonky anchored_tabletop_offset rendering (#85372) ## About The Pull Request While working out railing layering rank, I noticed this issue: ![image](https://github.com/user-attachments/assets/d6a21016-23c1-48f7-821f-fdb38a351232) This seems to be because we allow objects to have their `pixel_y` be offset when anchored on top of a table, which causes it to peek into the next tile up, thus layering us on top of it. Making it use `pixel_z` instead such that it's only visually offset fixes this: ![image](https://github.com/user-attachments/assets/21051291-424a-422c-ad9c-aa71cb58c5ee) Additionally, while we're touching the `check_on_table()` proc, we make it remove the `pixel_z` offset whenever it gets unanchored instead of only whenever it gets unanchored _on a table_. Ideally we would also make such vertically offset objects remove their offset when the table they're on gets destroyed, but that's not the point of this pr. ## Why It's Good For The Game Tends to be better to not look like you're standing on something you're not. It's a bit annoying when you destroy the table under a vertically offset object and now can't remove that offset until you put it on a table again. ## Changelog :cl: fix: You no longer render on top of tall enough objects that get vertically offset when anchored to a table when standing on the tile directly to the north of them. Examples are soda and booze dispensers. fix: Removing the vertical offset some objects get when anchored to a table can be done by unanchoring it at any point, rather than only on a table. /:cl: * Fix some wonky anchored_tabletop_offset rendering --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]> * [MIRROR] Fix some wonky anchored_tabletop_offset rendering --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]> Co-authored-by: StealsThePRs <[email protected]>
- Loading branch information