Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Flowise embed repositories into Flowise monorepo #1639

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

0xi4o
Copy link
Contributor

@0xi4o 0xi4o commented Jan 30, 2024

Why do this?

  • All the bugs and feature requests can be tracked in one place
  • Dev Experience: Building features for the embeds is quite hard since every change requires us to build it and test it in an external demo app. This will add a demo app for testing changes for sdks (and also it'll be easier if we want to support more frontend frameworks like Svelte, Vue, etc)
  • Setup workflows for the sdks

@0xi4o 0xi4o self-assigned this Jan 30, 2024
@0xi4o 0xi4o marked this pull request as draft January 30, 2024 11:10
@automaton82
Copy link
Contributor

I think this is a good idea, but if I can make a suggestion: it would be very nice if building the web.js also output it into the ui/public folder. This way it can also be hosted by Flowise itself, instead of relying on a CDN. This has the added advantage of any changes being done in the embed bot will be immediately reflected.

The embed sample can also be updated to use the local version instead of CDN, or both.

Also this would eliminate the dist folder from the embed repo which would be good, it probably shouldn't be there to begin with.

@0xi4o
Copy link
Contributor Author

0xi4o commented Feb 1, 2024

@automaton82 Great suggestion. I'll add that as well. I'm also including a demo project for testing the embeds. This should help us iterate on changes in embeds quickly.

But I'll keep the dist folder for now, just in case someone wants to download the build output from Github. Later I want to have downloadable files under Releases at which point we can remove the dist folder completely.

@0xi4o 0xi4o marked this pull request as ready for review February 6, 2024 04:37
@HenryHengZJ
Copy link
Contributor

@0xi4o let me know if this is ready for review, and the errors on the CI/CD are fixed (linting issues)

@HenryHengZJ
Copy link
Contributor

@0xi4o let me know if this is ready for review, and the errors on the CI/CD are fixed (linting issues)

putting on hold until #1272 is merged

@BigFoxMedia
Copy link

👍
#1272 is merged, hope to see this merged too :) Do you guys need any help with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants