Layout does not edit the ui-spacer node with editConfig
#1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepavitt
approved these changes
Jan 10, 2025
|
Thanks @GogoVega! |
|
I noticed the issue also existed for new spacers added as well, so just pushed a fix for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discourse.nodered.org/t/bug-when-adding-spacer-dashboard-2/94316
Description
In #1516, the prefix to use in input element identifiers has been replaced by
node-config-input.Until now the layout treated
ui-spaceras a normal node and edited it withRED.editor.edit()which uses thenode-inputprefix. This is why the input is no longer prepared (the selection is missing).Related Issue(s)
#1516
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel