ui-page: layout editor button #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GogoVega
reviewed
Jan 9, 2025
Co-authored-by: Gauthier Dandele <[email protected]>
joepavitt
approved these changes
Jan 10, 2025
…ex-layout # Conflicts: # nodes/config/ui_base.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shows a button in the ui-page config screen, to open the layout manager:
The alignment of the button isn't really nice, because it would look better if it was right-aligned with all other elements in the config screen. But there seems to be quite some CSS going on. Would be nice if anybody could tweak it a bit better.[EDIT 10/01/2025] The alignment problem is now solved, thanks to @GogoVega :
BTW I have used a global function, so that the same function can be reused in the ui-page config screen. I didn't want to duplicate code, because that will run out of sync after a while anyway. I tried to put it as an extra custom function in the ui-base type object, but Node-RED seems to strip off all functions that it doesn't expect. I used quite a long name for the global function, in order to avoid conflicts with a future new global function with the same name. If you have better idea than a global function to accomplish this, please let me know and I will adjust it.
Related Issue(s)
1505
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel