Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre release niggles #1546

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Pre release niggles #1546

merged 2 commits into from
Dec 20, 2024
+3 −3

Conversation

Steve-Mcl
Copy link
Contributor

Description

  1. error with empty table
    image
    image
  2. groups widths not same as prior release
    before
    image
    after
    image

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt December 19, 2024 19:48
@Steve-Mcl
Copy link
Contributor Author

@joepavitt

Just the usual flaky widgets/control.spec.js fail

Good for 1.21.0 release once this is merged.

@Steve-Mcl Steve-Mcl requested review from knolleary and removed request for joepavitt December 20, 2024 09:08
@Steve-Mcl Steve-Mcl merged commit 8197214 into main Dec 20, 2024
1 of 2 checks passed
@Steve-Mcl Steve-Mcl deleted the pre-release-niggles branch December 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steve-Mcl @knolleary