-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unstable SemaphoreCI tests #2639
Conversation
await KeysScreen.checkKeysScreen([ekmKeySamples.key0]); | ||
// TODO: Temporarily disable the logic below as the cancel button on the refresh screen | ||
// is not functioning correctly in Semaphore CI for some reason. | ||
// https://flowcrypt.semaphoreci.com/workflows/7310b5b7-d544-428c-82ce-7f7f060e7e60?pipeline_id=186f2ad1-5d22-44d3-ba07-76deaf3ea49f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sosnovsky Have any idea why this test fails (can't click button even though elements are visible on the screen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be caused by some changes in iOS behavior which were adapted in the newer Appium version.
After upgrading to the latest Appium we can re-check if it works there.
@sosnovsky I’ve fixed most of the unstable tests, but in a few cases, they still occasionally fail on SemaphoreCI. The main issue seems to be a 2-hour timeout limit we set in SemaphoreCI config, where tests get stuck on the home screen (with a list of apps in a closed state) or on the loading progress HUD. Let me know your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for checking out, hope it'll help to make tests passing in the new PRs 👍
It should be ok for now, as previously it was almost impossible to make all tests pass. |
This PR fixed unstable SemaphoreCI tests.
close #2638 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):