Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2525 Use macos-xcode15 image on semaphore #2527

Merged
merged 20 commits into from
Apr 4, 2024
Merged

#2525 Use macos-xcode15 image on semaphore #2527

merged 20 commits into from
Apr 4, 2024

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Feb 15, 2024 •
edited
Loading

This PR updates semaphore.yml to use macos-xcode15 image and also swiftformat config to use swift 5.9

close #2525

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from ioanmo226 April 4, 2024 17:28
@sosnovsky sosnovsky marked this pull request as ready for review April 4, 2024 17:29
@sosnovsky sosnovsky requested a review from tomholub as a code owner April 4, 2024 17:29
ioanmo226
ioanmo226 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ioanmo226 ioanmo226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioanmo226 ioanmo226 merged commit 4175683 into master Apr 4, 2024
11 checks passed
@ioanmo226 ioanmo226 deleted the 2525-semaphore-xcode15 branch April 4, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanmo226 ioanmo226 ioanmo226 approved these changes

@tomholub tomholub Awaiting requested review from tomholub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use macos-xcode15 image on Semaphore
2 participants
@sosnovsky @ioanmo226