Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#418 Updated recipient selection color #2298

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Jul 28, 2023

This PR updated recipient selection color

close #418 // if this PR closes an issue
close #2304 // if this PR closes an issue

image
image


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review July 28, 2023 06:12
@ioanmo226
Copy link
Collaborator Author

Let me know if you have better suggestion.

@sosnovsky
Copy link
Collaborator

It's still not very clear that recipient is selected - looks like just some another state, I would think that recipient wasn't selected and will try to select it by tapping.

What about just reducing opacity of selected recipient to 0.6:

Screenshot 2023-07-28 at 14 09 02

Then it'll still be possible to see current state of recipient (key found, no key etc), but reduced opacity will show that it is currently selected. Plus I think we should remove typing cursor when recipient is selected, as it's not common to have something selected and active cursor simultaneously (you can check how it works in iOS Messages or Mail app)

@ioanmo226
Copy link
Collaborator Author

Cool thought! But here's the thing, to me, it feels like 100% opacity gives off a "selected" vibe, while 50% opacity seems more "unselected", What do you think?

@sosnovsky
Copy link
Collaborator

Cool thought! But here's the thing, to me, it feels like 100% opacity gives off a "selected" vibe, while 50% opacity seems more "unselected", What do you think?

Yeah, I agree on this but haven't come up with something better yet :) Probably it'll still be more clear than just switching recipient color to blue.
Among other ideas there were making font bold or changing border color and width, but not sure if it work well too.

@ioanmo226
Copy link
Collaborator Author

I agree. Let me proceed that way

@ioanmo226
Copy link
Collaborator Author

Setting opacity to 50% for keyNotFoundStateContext doesn't seem to work well. (As it already has alpha value of 0.1, doesn't have much visual difference even we set it to 0.05)
Is this fine?

image

@sosnovsky
Copy link
Collaborator

What about increasing alpha for keyNotFoundStateContext? For example to 0.3 or 0.4

@ioanmo226
Copy link
Collaborator Author

Ok

@ioanmo226
Copy link
Collaborator Author

@sosnovsky Ready for review

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

@sosnovsky sosnovsky merged commit 274ac5a into master Aug 1, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 418-tapping-delete-key-on-keyboard-to-just-added-recipient-wrongly-turns-it-gray branch August 1, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants