Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1955 Fixed missing backup query #2296

Merged
merged 1 commit into from
Jul 25, 2023
Merged

#1955 Fixed missing backup query #2296

merged 1 commit into from
Jul 25, 2023

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Jul 25, 2023 •
edited by sosnovsky
Loading

This PR fixed missing backup query issue

close #1955 // if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review July 25, 2023 07:38
sosnovsky
sosnovsky approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting why so many lines were removed in compiled core js file:
Screenshot 2023-07-25 at 21 58 26

But everything seems to work well 👍

@sosnovsky sosnovsky merged commit b907686 into master Jul 25, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 1955-missing-backup-query branch July 25, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

@tomholub tomholub Awaiting requested review from tomholub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing backup query
2 participants
@ioanmo226 @sosnovsky