#5848 Use Manifest V2 for Thunderbird Port #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
5 tasks
|
Hi @sosnovsky - I just added some tests from the last commit. It's ready for review again. thanks! |
sosnovsky
reviewed
Oct 10, 2024
…fest-v2-for-thunderbird
|
Hello @sosnovsky, may I request another review? Thank you! |
sosnovsky
reviewed
Oct 14, 2024
|
Hi @sosnovsky - It is now good to go. thank you! |
sosnovsky
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the manifest version used by the Thunderbird Port from v3 to v2 due to unstable support of Thunderbird Typescript typings for Thunderbird ESR 128 and above.
close #5848
issue #5786
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):