Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce GlobalStore accounts in addition to sessionStorage removal #5849

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Oct 9, 2024

This PR updates the data from GlobalStore storage making it syncronized when accounts from sessionStorage is removed. This update helps determining unconnected accounts in an event of account reset.

close #5797


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil marked this pull request as draft October 9, 2024 06:52
@martgil martgil marked this pull request as ready for review October 9, 2024 07:28
@martgil

This comment was marked as outdated.

extension/js/common/platform/store/global-store.ts Outdated Show resolved Hide resolved
extension/js/common/settings.ts Outdated Show resolved Hide resolved
@martgil
Copy link
Collaborator Author

martgil commented Oct 10, 2024

Hi @sosnovsky - this is all good now. thanks!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky merged commit d70bf0f into master Oct 10, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5797-added-better-detection-for-configured-accounts-during-reset branch October 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce items on GlobalStore.get(['account_emails']) when users perform reset (logout)
2 participants