Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5838 Added checks for RichText() before initializing squire in Secure Reply message box #5845

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Sep 26, 2024

This PR fixes squire initialization for secure compose message box where newlines gets injected above the current line when Enter is pressed.

close #5838


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil marked this pull request as draft September 26, 2024 08:01
@martgil martgil marked this pull request as ready for review September 26, 2024 11:45
@martgil
Copy link
Collaborator Author

martgil commented Sep 26, 2024

Hi @sosnovsky - this one is ready for review. Thank you!

@martgil
Copy link
Collaborator Author

martgil commented Sep 27, 2024

Hi @sosnovsky - Greetings. May I request for another review. thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky merged commit a1b8448 into master Sep 30, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5838-fix-incorrect-newlines-secure-reply-box branch September 30, 2024 06:31
@martgil
Copy link
Collaborator Author

martgil commented Sep 30, 2024

thank you, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect newlines when composing reply message
2 participants