#5839 Fix parsing noname attachment with "message/global" content type

[sosnovsky]

This PR fixes incorrect parsing of noname attachments with message/global content type in plain messages.

close #5839

---

Tests (delete all except exactly one):

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[sosnovsky]

Hi @martgil, this PR is ready for review, thanks!

[martgil]

Looks good to me – I just noticed one minor thing that could be improved, but it’s definitely not an issue.

[sosnovsky]

Looks good to me – I just noticed one minor thing that could be improved, but it’s definitely not an issue.

Hi @martgil, didn't find this minor thing, can you please describe what can be improved, thanks!

[sosnovsky]

Looks good to me – I just noticed one minor thing that could be improved, but it’s definitely not an issue.

Hi @martgil, can you please describe mentioned improvement, thanks!

[martgil]

Hi @martgil, can you please describe mentioned improvement, thanks!

Thanks @sosnovsky, I'm referring to this one: https://github.com/FlowCrypt/flowcrypt-browser/pull/5844/files#diff-fb2223e49c2a9c6a1085bdbe7eb8e17e3ee803132833d5e90d49faf5a3e8d2faR232-R237

I feel like this function should be renamed to shouldBeHidden(), in case of the following test:

if (renderStatus === 'hidden' || a.isHidden()) {
        nRenderedAttachments--;
      }

since there's an action that depends on it that requires reduction for attachment that is supposed to be hidden. The function isHidden() sounds like a test for attachment that is hidden or not. Not a big deal though.

[sosnovsky]

Agree on this, shouldBeHidden better describes original property, thanks for noticing!
I renamed it, please re-check

[martgil]

all good now, thank you!